Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Integration tests skipped with Redis cluster should be fixed #49285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Feb 7, 2023 · 0 comments · Fixed by #49449
Closed

Integration tests skipped with Redis cluster should be fixed #49285

nicolas-grekas opened this issue Feb 7, 2023 · 0 comments · Fixed by #49449
Labels
Help wanted Issues and PRs which are looking for volunteers to complete them.

Comments

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Feb 7, 2023 •
edited
Loading

Our integration tests skip many Redis tests with:
Failed to retrieve master information from master name "" and address "127.0.0.1:7006".

See latest jobs on https://github.com/symfony/symfony/actions/workflows/integration-tests.yml?query=branch%3A6.3
@nicolas-grekas nicolas-grekas added the Help wanted Issues and PRs which are looking for volunteers to complete them. label Feb 7, 2023
This was referenced Feb 20, 2023
Merged
Merged
Closed
nicolas-grekas added a commit that referenced this issue Feb 21, 2023
@nicolas-grekas
minor #49449 Fix Integration tests skipped with Redis cluster (maxbec…
1851e89 
…kers)

This PR was merged into the 6.3 branch.

Discussion
----------

Fix Integration tests skipped with Redis cluster

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #49285
| License       | MIT
| Doc PR        | n/a

It seems to me, that the `getenv('MESSENGER_REDIS_SENTINEL_MASTER')` in the `setUp()` might return `false` because it's unset. To ignore the sentinel, it must be null:
https://github.com/symfony/symfony/blob/090033332fa4eb5e7475111136b1cce260edffa4/src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php#L95-L100

Commits
-------

e263666 Fix Integration tests skipped with Redis cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help wanted Issues and PRs which are looking for volunteers to complete them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Integration tests skipped with Redis cluster maxbeckers/symfony
1 participant
@nicolas-grekas