-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Wrong authors' GitHub accout links in release notes #49298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ping @fabpot |
This file lists usernames from https://connect.symfony.com, not github. |
@nicolas-grekas then it should not use the |
Or put a zero-width space in between the |
Isn't it possible to use the Github handle instead? |
Well, it is the reason why release notes have wrong links. Knowing it is a good start for fixing them. By the way, not all contributors have a Symfony Connect account. |
So, I checked the code, which is in symfony/gh We have a simple heuristic in gh which is to not add the "@" prefix when the contributor contains a space. We're going to do the same in release notes. That's no 100% perfect but that's a bit better. |
Symfony version(s) affected
all
Description
I've spotted that sometimes links to authors have issues.
For example #48687
Titouan Galopin account is @tgalopin and João Nogueira is @joaopbnogueira
I haven't seen the script that produces release notes to say why it happens.
How to reproduce
See #48687
Possible Solution
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: