Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Wrong authors' GitHub accout links in release notes #49298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
upyx opened this issue Feb 8, 2023 · 7 comments
Closed

Wrong authors' GitHub accout links in release notes #49298

upyx opened this issue Feb 8, 2023 · 7 comments

Comments

@upyx
Copy link
Contributor

upyx commented Feb 8, 2023

Symfony version(s) affected

all

Description

I've spotted that sometimes links to authors have issues.

For example #48687

Titouan Galopin account is @tgalopin and João Nogueira is @joaopbnogueira

I haven't seen the script that produces release notes to say why it happens.

How to reproduce

See #48687

Possible Solution

No response

Additional Context

No response

@OskarStark
Copy link
Contributor

ping @fabpot

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Feb 24, 2023

This file lists usernames from https://connect.symfony.com, not github.

@stof
Copy link
Member

stof commented Feb 24, 2023

@nicolas-grekas then it should not use the @ prefix as that makes GitHub treat them as GitHub mentions

@wouterj
Copy link
Member

wouterj commented Feb 24, 2023

Or put a zero-width space in between the @ and the username. @​wouterj 😉

@OskarStark
Copy link
Contributor

Isn't it possible to use the Github handle instead?

@upyx
Copy link
Contributor Author

upyx commented Feb 26, 2023

This file lists usernames from https://connect.symfony.com, not github.

Well, it is the reason why release notes have wrong links. Knowing it is a good start for fixing them.

By the way, not all contributors have a Symfony Connect account.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 13, 2023

So, I checked the code, which is in symfony/gh
and I was wrong, this doesn't happen because of any link to SymfonyConnect, but because the committer isn't linked to their github account, as in https://api.github.com/repos/symfony/symfony/pulls/47979/commits

We have a simple heuristic in gh which is to not add the "@" prefix when the contributor contains a space. We're going to do the same in release notes. That's no 100% perfect but that's a bit better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants