Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HtmlSanitizer] Fix HtmlSanitizer default configuration behavior for allowed schemes #48602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2022
Merged

[HtmlSanitizer] Fix HtmlSanitizer default configuration behavior for allowed schemes #48602

merged 1 commit into from
Dec 14, 2022

Conversation

tgalopin
Copy link
Contributor

Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #48556
License MIT
Doc PR -

This issue happened not in the component but in the default configuration behavior (array was passed instead of null).

@carsonbot carsonbot added this to the 6.3 milestone Dec 11, 2022
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.1".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@tgalopin tgalopin changed the title Fix HtmlSanitizer default configuration behavior for allowed schemes [HtmlSanitizer] Fix HtmlSanitizer default configuration behavior for allowed schemes Dec 11, 2022
@tgalopin tgalopin mentioned this pull request Dec 11, 2022
Closed
@tgalopin tgalopin changed the base branch from 6.3 to 6.1 December 11, 2022 18:13
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.1 Dec 14, 2022
nicolas-grekas
nicolas-grekas approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Null is not an allowed value for allowLinkSchemes(), so I fixed the code.

@nicolas-grekas nicolas-grekas force-pushed the fix/htmlsanitizer-default-allow-schemes branch from e148e95 to 93e5160 Compare December 14, 2022 10:29
@nicolas-grekas
Copy link
Member

Thank you @tgalopin.

@nicolas-grekas nicolas-grekas merged commit f14901e into symfony:6.1 Dec 14, 2022
@tgalopin tgalopin deleted the fix/htmlsanitizer-default-allow-schemes branch December 14, 2022 11:22
@fabpot fabpot mentioned this pull request Dec 16, 2022
Merged
@fabpot fabpot mentioned this pull request Dec 28, 2022
Merged
@upyx upyx mentioned this pull request Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug HtmlSanitizer Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

[HtmlSanitizer] Allow href attributes in links by default
3 participants
@tgalopin @carsonbot @nicolas-grekas