-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
PropertyInfo PhpStanExtractor is incompatible with version 2.0 of phpstan/phpdoc-parser #58796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Supporting both versions of the package should be easy (for 2.0, we need to create a config object in its default config and pass it to all those constructors instead of using those constructors with their default constructor arguments), so I suggest we add support for version 2.0 in a patch release |
PR welcome. |
I'm on it |
see #58800 |
…er 2 (xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [Serializer][TypeInfo] fix support for phpstan/phpdoc-parser 2 | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | related to #58796 | License | MIT Commits ------- ecb34a7 fix support for phpstan/phpdoc-parser 2
Also for others, if you use
but the PR #58804 from @xabbuh resolves this, so we only need to wait for a next release at the |
Symfony version(s) affected
5.4, 6.4, 7.2
Description
A new version of PHPStan's parser has been released (2.0.0).
Installation with 2.0.0 causes issues with the following code:
symfony/src/Symfony/Component/PropertyInfo/Extractor/PhpStanExtractor.php
Line 82 in 3ee7490
Because
ConstExprParser
now has required constructor arguments.Since this is an optional dependency, how are we going to handle it?
How to reproduce
In my case it was any project using
symfony/serializer-pack
. Since this also installed thephpstan/phpdoc-parser
with any version, I received 2.0.0.Possible Solution
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: