[Console] Error calling Input::getArguments()/getOptions() on empty input #5935

alwynn · 2012-11-08T08:14:48Z

Problem

When trying to retrieve arguments and/or options of the input in overloaded Symfony\Component\Console\Application::doRun() an error occurs as follows:

Getting arguments

public function doRun(InputInterface $input, OutputInterface $output)
{
    $arguments = $input->getArguments();
    // ...
    return parent::doRun($input, $output);
}

Getting options

public function doRun(InputInterface $input, OutputInterface $output)
{
    $options = $input->getOptions();
    // ...
    return parent::doRun($input, $output);
}

Both result in ErrorException being thrown after calling the console script (no matter the arguments and options list):

[ErrorException]                            
array_merge(): Argument #2 is not an array

This behaviour is a direct result of properties Symfony\Component\Console\Input\Input::$options and Symfony\Component\Console\Input\Input::$attributes being set to null and not an empty array.

Proposed solution

Set default value of $options and $attributes properties to empty array.

abstract class Input implements InputInterface
{
    protected $definition;
    protected $options = array();
    protected $arguments = array();
    // ...
}

Symfony console installed as a composer asset in version v2.1.3 (as composer.lock file states).

* 2.0: updated license year Update src/Symfony/Component/HttpFoundation/Response.php [Console] fixed unitialized properties (closes #5935) [Bundle] [FrameworkBundle] fixed typo in phpdoc of the SessionListener. bumped Symfony version to 2.0.21-DEV updated VERSION for 2.0.21 updated CHANGELOG for 2.0.21 Conflicts: src/Symfony/Bundle/SwiftmailerBundle/LICENSE src/Symfony/Component/Filesystem/LICENSE src/Symfony/Component/HttpFoundation/Response.php src/Symfony/Component/HttpKernel/Kernel.php

* 2.1: (24 commits) updated license year Update src/Symfony/Component/HttpFoundation/Response.php [Form] Fixed inheritance of "error_bubbling" in RepeatedType [Form] Fixed DateType when used with the intl extension disabled. [HttpFoundation] fix return types and handling of zero in Response [HttpFoundation] better fix for non-parseable Expires header date Fixed missing plural message in portuguese validator Fix Expires when the header is -1 [DoctrineBridge] Allowing memcache port to be 0 to support memcache unix domain sockets. [Console] fixed unitialized properties (closes #5935) [Process] Prevented test from failing when pcntl extension is not enabled. Revert "[DoctrineBridge] Improved performance of the EntityType when used with the "query_builder" option" [Form] Fixed failing tests for DateTimeToStringTransformer. [Locale] Fixed the StubLocaleTest for ICU versions lower than 4.8. [Bundle] [FrameworkBundle] fixed typo in phpdoc of the SessionListener. [Form] Fixed test regression introduced in #6440 [Tests] Fix namespaces Fixed php doc of GenericEvent::__construct HttpUtils must handle RequestMatcher too use preferred_choices in favor of preferred_query ... Conflicts: src/Symfony/Bridge/Propel1/Form/ChoiceList/ModelChoiceList.php

* 2.0: updated license year Update src/Symfony/Component/HttpFoundation/Response.php [Console] fixed unitialized properties (closes symfony#5935) [Bundle] [FrameworkBundle] fixed typo in phpdoc of the SessionListener. bumped Symfony version to 2.0.21-DEV updated VERSION for 2.0.21 updated CHANGELOG for 2.0.21 Conflicts: src/Symfony/Bundle/SwiftmailerBundle/LICENSE src/Symfony/Component/Filesystem/LICENSE src/Symfony/Component/HttpFoundation/Response.php src/Symfony/Component/HttpKernel/Kernel.php

fabpot added a commit to fabpot/symfony that referenced this issue Dec 30, 2012

[Console] fixed unitialized properties (closes symfony#5935)

2fc41a1

fabpot closed this as completed Jan 2, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Console] Error calling Input::getArguments()/getOptions() on empty input #5935

[Console] Error calling Input::getArguments()/getOptions() on empty input #5935

alwynn commented Nov 8, 2012

Uh oh!

[Console] Error calling Input::getArguments()/getOptions() on empty input #5935

[Console] Error calling Input::getArguments()/getOptions() on empty input #5935

Comments

alwynn commented Nov 8, 2012

Problem

Proposed solution