-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Translation] Add support for the MessageFormatter class #6009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@guilhermeblanco what do you think about this? I still haven't looked at the class so deep, but I agree that using a common php ext/library would be better that writing the component from scratch. |
F*ck! It totally makes sense. |
+1 that would make it easier |
@DavidBadura Have a look at https://github.com/webfactory/icu-translation-bundle. We developed that bundle specifically for message formatting. Might help. |
I have a yet to be finished patch laying around somewhere... will submit for 3.0. |
Any news on progress for this? |
@fkrauthan see linked PRs above |
@fkrauthan Will soon be closed by #18314 :) |
@HeahDude I just skipped thru that article and it seems like the step into the right direction but it seems like that https://github.com/webfactory/icu-translation-bundle would still be superior as it allows you to mix multiple formattings (e.g. select for gender + count + number formatting for count - see https://github.com/webfactory/icu-translation-bundle/blob/master/Resources/doc/index.rst#nested-conditions). Or will that be possible with #18314 too? |
…formatter (aitboudad) This PR was merged into the 3.4 branch. Discussion ---------- [Translation] added support for adding custom message formatter | Q | A | | --- | --- | | Branch? | master | | Bug fix? | no | | New feature? | yes | | BC breaks? | no | | Deprecations? | yes | | Tests pass? | yes | | Fixed tickets | #6009, #10152, one item in #11742, #11948 | | License | MIT | | Doc PR | ~ | Commits ------- 42183b0 [Translation] Support adding custom message formatter
Instead of reinventing wheel in #4797, #4884, #5547, we should use the MessageFormatter class. Read more:
The text was updated successfully, but these errors were encountered: