Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Translation] Add support for the MessageFormatter class #6009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hason opened this issue Nov 14, 2012 · 9 comments
Closed

[Translation] Add support for the MessageFormatter class #6009

hason opened this issue Nov 14, 2012 · 9 comments

Comments

@sroddy
Copy link

sroddy commented Dec 5, 2012

@guilhermeblanco what do you think about this? I still haven't looked at the class so deep, but I agree that using a common php ext/library would be better that writing the component from scratch.

@guilhermeblanco
Copy link
Contributor

F*ck! It totally makes sense.
It'd simplify the code a lot.

@DavidBadura
Copy link
Contributor

+1 that would make it easier

@Matthimatiker
Copy link

@DavidBadura Have a look at https://github.com/webfactory/icu-translation-bundle. We developed that bundle specifically for message formatting. Might help.

@guilhermeblanco
Copy link
Contributor

I have a yet to be finished patch laying around somewhere... will submit for 3.0.
I also did the same work as webfactory's, but I deal with fallbacks too, so if it doesn't work with Intl, it tries the Symfony old style.

@fkrauthan
Copy link

Any news on progress for this?

@Koc
Copy link
Contributor

Koc commented Dec 19, 2016

@fkrauthan see linked PRs above

@HeahDude
Copy link
Contributor

@fkrauthan Will soon be closed by #18314 :)

@fkrauthan
Copy link

@HeahDude I just skipped thru that article and it seems like the step into the right direction but it seems like that https://github.com/webfactory/icu-translation-bundle would still be superior as it allows you to mix multiple formattings (e.g. select for gender + count + number formatting for count - see https://github.com/webfactory/icu-translation-bundle/blob/master/Resources/doc/index.rst#nested-conditions). Or will that be possible with #18314 too?

xabbuh added a commit that referenced this issue Sep 12, 2017
…formatter (aitboudad)

This PR was merged into the 3.4 branch.

Discussion
----------

[Translation] added support for adding custom message formatter

| Q | A |
| --- | --- |
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #6009, #10152, one item in #11742, #11948 |
| License | MIT |
| Doc PR | ~ |

Commits
-------

42183b0 [Translation] Support adding custom message formatter
@xabbuh xabbuh closed this as completed Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants