Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BrowserKit] Form names with . are converted to _ (breaks compatibility with non-PHP forms) #6908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
relaxnow opened this issue Jan 29, 2013 · 1 comment
Closed

[BrowserKit] Form names with . are converted to _ (breaks compatibility with non-PHP forms) #6908

relaxnow opened this issue Jan 29, 2013 · 1 comment
Labels
BrowserKit Enhancement Good first issue Ideal for your first contribution! (some Symfony experience may be required)

Comments

@relaxnow
Copy link

Symfony/Component/BrowserKit/Client->submit uses $form->getPhpValues() which uses parsestr which automagically converts . to _, this breaks compatibility with forms intended for non-PHP services.

Background
I am trying to write a functional test for connecting to an OpenID2 implementation in ASP.NET, however this requires use of a (auto-submitted by javascript) form with names like hidden form names like openid.mode.
@relaxnow
Copy link
Author

relaxnow commented Apr 4, 2013

Note that I've fixed this in a fork: relaxnow/BrowserKit@4076591

@fabpot fabpot mentioned this issue Sep 12, 2013
Closed
cordoval added a commit to cordoval/symfony that referenced this issue Dec 9, 2013
@cordoval
fix symfony#6908 replacing dots with underscores
5c365b4
@cordoval cordoval mentioned this issue Dec 9, 2013
Closed
@robbertkl robbertkl mentioned this issue Feb 3, 2014
Closed
@romainneutron romainneutron mentioned this issue Mar 13, 2014
Merged
fabpot added a commit that referenced this issue Mar 14, 2014
@fabpot
bug #10444 [DomCrawler] Fixed incorrect value name conversion in getP…
79e92f9 
…hpValues() and getPhpFiles() (romainneutron)

This PR was merged into the 2.3 branch.

Discussion
----------

[DomCrawler] Fixed incorrect value name conversion in getPhpValues() and getPhpFiles()

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6908
| License       | MIT

This PR replaces #10193

Commits
-------

89c599e [DomCrawler] Add tests for recursive cases of getPhpValues() and getPhpFiles()
e961f57 [DomCrawler] Fixed incorrect value name conversion in getPhpValues() and getPhpFiles()
@fabpot fabpot closed this as completed Mar 14, 2014
@kkopachev kkopachev mentioned this issue Oct 3, 2014
Merged
@ostrolucky ostrolucky mentioned this issue Apr 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BrowserKit Enhancement Good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @relaxnow