Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Console] Clean the unit tests #6935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vicb opened this issue Feb 1, 2013 · 4 comments
Closed

[Console] Clean the unit tests #6935

vicb opened this issue Feb 1, 2013 · 4 comments
Labels
Console Enhancement Good first issue Ideal for your first contribution! (some Symfony experience may be required)

Comments

@vicb
Copy link
Contributor

vicb commented Feb 1, 2013

Each of the unit test methods should be splitted in smaller blocks, see InputOptionTest for a bad example.
@jakzal
Copy link
Contributor

jakzal commented Feb 1, 2013

I'll pick it up. @vicb I guess it should be done in 2.1?

@vicb
Copy link
Contributor Author

vicb commented Feb 1, 2013

master (as not a bug fix)

@vicb
Copy link
Contributor Author

vicb commented Feb 1, 2013

thanks... but please wait one day, I am fixing them before :)

@vicb
Copy link
Contributor Author

vicb commented Feb 1, 2013

well will be for next beginning of next week, pending a reply for fabpot. Feel free to go ahead before if you wish.

@jakzal jakzal mentioned this issue Feb 6, 2013
Merged
fabpot added a commit that referenced this issue Apr 9, 2013
@fabpot
merged branch jakzal/console-tests-cleanup (PR #6989)
6f0a5ad 
This PR was merged into the master branch.

Discussion
----------

[Console] Cleaned up the unit tests.

Cleaned up some unit tests in the Console component as suggested in #6935. I didn't fully cleanup the Application tests to not to delay this PR. I might do it later as a separate one.

| Q              | A                                        |
|--------------|--------------------------------|
| Bug fix?          | no |
|New feature? | no |
|BC breaks?    | no |
|Deprecations? |	no |
|Tests pass? | yes |
|Fixed tickets | #6935 |
|License | MIT |
|Doc PR | n/a |

Commits
-------

5ca04b0 [Console] Cleaned up the unit tests.
@fabpot fabpot closed this as completed Apr 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Console Enhancement Good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @jakzal @vicb