Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Security] Bcrypt encoder's method declarations are not compatible with interface #6974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shoomyth opened this issue Feb 5, 2013 · 0 comments
Closed

[Security] Bcrypt encoder's method declarations are not compatible with interface #6974

shoomyth opened this issue Feb 5, 2013 · 0 comments

Comments

@shoomyth
Copy link

shoomyth commented Feb 5, 2013

BCryptPasswordEncoder:
public function encodePassword($raw, $salt = null)
public function isPasswordValid($encoded, $raw, $salt = null)

PasswordEncoderInterface:
public function encodePassword($raw, $salt);
public function isPasswordValid($encoded, $raw, $salt);

In bcrypt encoder salt is optional and in interface is not. IDE marks this as error (warning)
fabpot added a commit that referenced this issue Feb 5, 2013
@fabpot
[Security] fixed interface implementation (closes #6974)
0c20a5a
@fabpot fabpot closed this as completed Feb 5, 2013
fabpot added a commit that referenced this issue Feb 7, 2013
@fabpot
Merge branch '2.2'
8df7732 
* 2.2:
  [HttpFoundation] fixed Request::create() method
  [HttpKernel] fixed the creation of the Profiler directory
  [HttpKernel] fixed the hinclude fragment renderer when the template is empty
  bumped Symfony version to 2.2.0-RC2-DEV
  [DependencyInjection] enhanced some error messages
  [FrameworkBundle] fixed typo
  fixed typo
  tweaked previous merge
  [Security] fixed interface implementation (closes #6974)
  Add "'property_path' => false" deprecation message for forms
  fixed CS
  Added BCrypt password encoder.
  updated VERSION for 2.2.0-RC1
  Removed underscores from test method names to be consistent with other components.
  [Security] fixed session creation when none is needed (closes #6917)
  [FrameworkBundle] removed obsolete comment (see 2e356c1)
  Micro-optimization
  [FrameworkBundle] removed extra whitespaces
  [Security] renamed Constraint namespace to Constraints for validator classes in order to be consistent with the whole current validator API.
  [FrameworkBundle] fixed wrong indentation on route debug output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @shoomyth