Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpKernel] HInclude FragmentRenderer broken #7113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kingcrunch opened this issue Feb 18, 2013 · 0 comments
Closed

[HttpKernel] HInclude FragmentRenderer broken #7113

kingcrunch opened this issue Feb 18, 2013 · 0 comments

Comments

@kingcrunch
Copy link
Contributor

The change of a the visbility of the property $templating from protected to private in a313188#L1R29 breaks the subclass ContainerAwareHIncludeFragmentRenderer at a313188#L0R43

if (!$this->templating) {
    $this->setTemplating($this->container->get('templating'));
}

The hinclude-fragment-renderer is not useable anymore.

fabpot added a commit to fabpot/symfony that referenced this issue Feb 19, 2013
fabpot added a commit that referenced this issue Feb 20, 2013
This PR was merged into the 2.2 branch.

Commits
-------

3933912 fixed HInclude renderer (closes #7113)

Discussion
----------

fixed HInclude renderer (closes #7113)

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7113
| License       | MIT
| Doc PR        | n/a

---------------------------------------------------------------------------

by stof at 2013-02-19T08:36:20Z

:+1:
@fabpot fabpot closed this as completed Feb 20, 2013
fabpot added a commit that referenced this issue Feb 23, 2013
* 2.2:
  Defined stable version point of Doctrine.
  [HttpFoundation] Remove Cache-Control when using https download via IE<9 (fixes #6750)
  Update composer.json
  [Form] Fixed TimeType not to render a "size" attribute in select tags
  [Form] Added test for "label" option to accept the value "0"
  Expanded fault-tolerance for unusual cookie dates
  Fix docblock type
  [Form] Fixed "label" option to accept the value "0"
  Added greek translation
  merged branch jfcixmedia/2.1 (PR #5838)
  added a note about a BC break for the path info of sub-request (closes #7138)
  [DomCrawler] lowered parsed protocol string (fixes #6986)
  [FrameworkBundle] Fix a BC for Hinclude global template
  [HttpKernel] fixed locale management when exiting sub-requests
  fixed HInclude renderer (closes #7113)
  Removed some leaking deprecation warning in the Form component
  [HttpKernel] hinclude fragment renderer must escape URIs properly to return valid html

Conflicts:
	src/Symfony/Bundle/FrameworkBundle/composer.json
	src/Symfony/Component/Security/composer.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants