-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[RFC][Config] Split Config component? #7796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
caching is atm a bit all over the place in Symfony2 and unfortunately we will not have a proper cache component (or blessed 3rd party lib) by 2.3 .. but we can think about what kind of things we could today to prepare for the day when we do have such a thing. |
In the recent discussions about the "Cache component", I had the impression that it mostly aims at having something like Doctrine Cache, APC or the like. ConfigCache is very different from that, but nonetheless it might end up in such a component. |
@lsmith77 the ConfigCache here is a different thing than the Cache component, with a different use case. There is a small issue in your description through. the resources are also used by the ConfigCache part. They are not only for loaders. The main drawback of such a split is the BC break IMO. Otherwise, I'm all in favor of splitting things as the loaders and the Definition stuff are 2 different unrelated features (except for the fact that you will often use a loader to build the array passed to the Configuration) |
The "Resources" (ResourceInterface et al) are not even used by loaders. Loaders only talk about loading "resources", but that's just strings identifying something.
|
Well, resources are handled by the child classes of the loader implementing the actual loading logic, as the way resources are gathered also depend of the case. See the loader implementations in the DI and Routing components. |
@stof do you still consider this split worthwhile? |
I think it's not worthwhile |
Ok, you guys decide – feel free to close it. |
If I am not overlooking something, the Config component consists of three things that have little to nothing to do with each other:
I came across a PR discussion lately (will try to find it again) in which (Drupal?) folks complained about depending on the Config component IIRC. Not sure whether the dependency itself was a problem or a dependency on too much/wrong stuff, though.
It was just an observation I wanted to log somewhere. If it was a deliberate decision, feel free to close it. Needless to say that'd be a BC break.
The text was updated successfully, but these errors were encountered: