You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have discovered that when I call session->start() method of Session Object, I can't close it properly, i.e method isStarted will always return true after I called session->start().
I checked Session & NativeSessionStorage in HttpFoundation folder and find out no methods set started property of storage to be false, that why isStarted always return true.
Where am I wrong?
I'm using symfony 2.2, thank you.
The text was updated successfully, but these errors were encountered:
…ession was closed (Taluu)
This PR was merged into the 2.2 branch.
Discussion
----------
[HttpFoundation] Do not return an empty session id if the session was closed
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7936
| License | MIT
| Doc PR | ~
A regression from the bug fix#9246 was introduced due to an incomplete fix ;
As the `started` flag on the NativeSessionStorage was not `true` anymore when saving the session, the session id was always empty when saving it, and thus when sending the `PHPSESSID` cookie.
The previous PR I made (#9530) was another approach to solve this regression, but this one should keep the fix made by @tecbot on #9246, and finish it with another verification. I may miss another place where `started` is used, but I don't really see which other conditions depending on this property should be altered...
**Note : this is #9611 rebased on 2.2**
This should be mergeable.
Commits
-------
5b9a727 When getting the session's id, check if the session is not closed
I have discovered that when I call session->start() method of Session Object, I can't close it properly, i.e method isStarted will always return true after I called session->start().
I checked Session & NativeSessionStorage in HttpFoundation folder and find out no methods set started property of storage to be false, that why isStarted always return true.
Where am I wrong?
I'm using symfony 2.2, thank you.
The text was updated successfully, but these errors were encountered: