Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WebProfiler] Disabling the toolbar should also deactivate the listener #8130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tobion opened this issue May 24, 2013 · 0 comments
Closed

[WebProfiler] Disabling the toolbar should also deactivate the listener #8130

Tobion opened this issue May 24, 2013 · 0 comments
Labels
WebProfilerBundle

Comments

@Tobion
Copy link
Contributor

Tobion commented May 24, 2013

Currently when

web_profiler:
    toolbar: false
    intercept_redirects: false

is set, the WebDebugToolbarListener is still executed (but disabled). Ideally it should not be executed at all.
Both options must be false because they are indepentend of each other. Its quite irritating that toolbar option maps to WebDebugToolbarListener::DISABLED/ENABLED because its not really disabled either because intercept_redirects can still be active.
@jfsimon jfsimon mentioned this issue Jul 31, 2013
Merged
fabpot added a commit that referenced this issue Aug 2, 2013
@fabpot
merged branch jfsimon/issue-8130 (PR #8615)
f678652 
This PR was merged into the master branch.

Discussion
----------

[WebProfilerBundle] make toolbar listener instantiation conditional

In the `WebProfilerBundle`, if `intercept_redirects` and `toolbar` options are both `false`, the `toolbar.xml` config file should not be loaded as the listener becomes useless.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8130

Commits
-------

17cbfc8 [WebProfilerBundle] made toolbar listener instantiation conditional
@fabpot fabpot closed this as completed Aug 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @Tobion