Exception when reflecting console Application class. #8200
Comments
|
It is an optional dependency of the component as the dispatcher is optional (you don't need to set a dispatcher to use the application). this is why the component is listed in the suggestions. |
|
Oh yes, I can see that setting the dispatcher is optional to the core functionality, but we are not using the event features and as a result of this change a previously working application has broken. It's definitely not a huge problem, as adding event-dispatcher as a dependency has gotten us going again, but I do believe it's harmful to shift the responsibility of managing these dependencies to the end-project. Just my 2c :) |
|
Well, that's the whole point of optional dependencies. That you need to activate them when u need them which is apparently the case when doing reflection. |
|
Indeed, I did not anticipate the BC break when using PHP reflection. Sorry for the inconvenience, but unfortunately, I don't see what we can do to "fix" this. |
|
Well, one could argue that ANY change to class is a bc break when using reflection. |
The
Console\Application::setDispatcher()method added in PR #7466 referencesEventDispatcherInterfaceas a type hint, howeversymfony/event-dispatcheris not listed as a runtime Composer dependency.This has caused a BC breakage when using reflection on the console
Applicationclass, in the form of the following exception:I'm not sure how this should be fixed, two possible solutions come to mind:
symfony/event-dispatcherfromrequire-devtorequireApplication::setDispatcher()As a workaround we've manually added
symfony/event-dispatcherto our project's composer.json, but this does not feel like a good solution as our app does not use the event features at all.The text was updated successfully, but these errors were encountered: