-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Consolidate repository names #8295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The name of package of standart edition is And there is a drawback: The api is not redirected => |
👎 package names are using different conventions than repository names, we should not make them equal imo. (btw, renaming Validator to Validation is something that I like more, but I don't think that's going to happen...) |
@lyrixx Are you sure? I thought it was. |
yes, see also symfony/symfony-standard#558 |
Thanks. I wrote a mail to the GitHub support, let's see how this turns out. |
@bschussek Yes, We got some issue during deploy because of this :( |
+1 |
Received a reply from the GitHub team:
I propose to postpone this issue until the API redirects are fixed. |
Don't know if this helps, but I told @fabpot about a similar issue on the sensio BuzzBundle last week (when sensio's repositories were renamed to "sensiolabs/*"). He fixes the issue really quickly (probably with a little tweak in packagist). So it's not a real 301 from the GitHub API, but it fixes the problem if you execute composer update to get the new API url in your |
@Swop it is still an issue with the API not redirecting. Updating packagist to use the new api url will not solve the issue for all projects locking the dependencies and having the old url in their lock file |
@stof Yeah sure, as I say: "it's not a real 301 from the GitHub API". |
Given that we are not 100% sure that everything will still work without problems after making the proposed changes, I think that it's safe to close this issue as won't fix. |
I don't agree with closing issues just because we canot fix them now. It's still a valid issue that should be handled at some point. |
The API is now redirected, so we might reconsider this issue. |
This naming standard is already used for the newer packages, so big +1 to make everything consistent (if it doesn't cause problems, but these should be solved by the redirection). |
Indeed, now that Github is doing the right thing, let's do that. I will try to make it happen this week. |
Done |
This PR was merged into the 2.3 branch. Discussion ---------- changed repo names to the new ones Part of symfony/symfony#8295 Ready to be merged as the repositories have already been renamed. Commits ------- 3a2f335 changed repo names to the new ones
Now that Github supports repository renaming with redirection I suggest to consolidate the repository names (a) with each other and (b) with their Composer package names (naming convention wise, i.e. lower case plus hyphens).
Status quo:
Better:
It's a small change, but it's worth it IMO (considering that there are no drawbacks).
The text was updated successfully, but these errors were encountered: