Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Consolidate repository names #8295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
webmozart opened this issue Jun 17, 2013 · 17 comments
Closed

Consolidate repository names #8295

webmozart opened this issue Jun 17, 2013 · 17 comments

Comments

@webmozart
Copy link
Contributor

Now that Github supports repository renaming with redirection I suggest to consolidate the repository names (a) with each other and (b) with their Composer package names (naming convention wise, i.e. lower case plus hyphens).

Status quo:

  • github.com/symfony/symfony (Composer: symfony/symfony)
  • github.com/symfony/symfony-standard (Composer: symfony/framework-standard-edition)
  • github.com/symfony/HttpFoundation (Composer: symfony/http-foundation)
  • github.com/symfony/DomCrawler (Composer: symfony/dom-crawler)
  • etc.

Better:

  • github.com/symfony/symfony (Composer: symfony/symfony)
  • github.com/symfony/symfony-standard (Composer: symfony/framework-standard-edition)
  • github.com/symfony/http-foundation (Composer: symfony/http-foundation)
  • github.com/symfony/dom-crawler (Composer: symfony/dom-crawler)

It's a small change, but it's worth it IMO (considering that there are no drawbacks).

@lyrixx
Copy link
Member

lyrixx commented Jun 17, 2013

The name of package of standart edition is symfony/framework-standard-edition https://packagist.org/packages/symfony/framework-standard-edition.

And there is a drawback: The api is not redirected => composer install does not work any more since the api is used by composer to download a package. (work only if you use --prefer-source

@wouterj
Copy link
Member

wouterj commented Jun 17, 2013

👎 package names are using different conventions than repository names, we should not make them equal imo.

(btw, renaming Validator to Validation is something that I like more, but I don't think that's going to happen...)

@webmozart
Copy link
Contributor Author

@lyrixx Are you sure? I thought it was.

@wouterj
Copy link
Member

wouterj commented Jun 17, 2013

yes, see also symfony/symfony-standard#558

@webmozart
Copy link
Contributor Author

Thanks. I wrote a mail to the GitHub support, let's see how this turns out.

@lyrixx
Copy link
Member

lyrixx commented Jun 17, 2013

@bschussek Yes, We got some issue during deploy because of this :(
You can see it with https://api.github.com/repos/sensio/SensioGeneratorBundle vs https://api.github.com/repos/sensiolabs/SensioGeneratorBundle

@dennisoehme
Copy link

+1

@webmozart
Copy link
Contributor Author

Received a reply from the GitHub team:

Hi, Bernhard,

Thanks for the question. We want to bring this feature to the API, but we're trying to figure out the best way to do so. While browsers and the Git CLI can handle it, many API clients don't deal with 301's very well. We're trying to take that into account. Keep an eye on the API docs for updates.

Cheers,


Wynn Netherland
Developer, GitHub
@pengwynn

I propose to postpone this issue until the API redirects are fixed.

@Swop
Copy link

Swop commented Jun 17, 2013

Don't know if this helps, but I told @fabpot about a similar issue on the sensio BuzzBundle last week (when sensio's repositories were renamed to "sensiolabs/*").

He fixes the issue really quickly (probably with a little tweak in packagist). So it's not a real 301 from the GitHub API, but it fixes the problem if you execute composer update to get the new API url in your composer.lock file.

@stof
Copy link
Member

stof commented Jun 17, 2013

@Swop it is still an issue with the API not redirecting. Updating packagist to use the new api url will not solve the issue for all projects locking the dependencies and having the old url in their lock file

@Swop
Copy link

Swop commented Jun 17, 2013

@stof Yeah sure, as I say: "it's not a real 301 from the GitHub API".
But let's wait, to see if the GitHub team will manage that issue (BTW, thanks @bschussek for the post to the GitHub team).

@javiereguiluz
Copy link
Member

Given that we are not 100% sure that everything will still work without problems after making the proposed changes, I think that it's safe to close this issue as won't fix.

@Tobion
Copy link
Contributor

Tobion commented Sep 6, 2014

I don't agree with closing issues just because we canot fix them now. It's still a valid issue that should be handled at some point.

@stof
Copy link
Member

stof commented Sep 20, 2015

The API is now redirected, so we might reconsider this issue.

@wouterj
Copy link
Member

wouterj commented Sep 20, 2015

This naming standard is already used for the newer packages, so big +1 to make everything consistent (if it doesn't cause problems, but these should be solved by the redirection).

@fabpot
Copy link
Member

fabpot commented Sep 21, 2015

Indeed, now that Github is doing the right thing, let's do that. I will try to make it happen this week.

@fabpot
Copy link
Member

fabpot commented Sep 23, 2015

Done

@fabpot fabpot closed this as completed Sep 23, 2015
xabbuh added a commit to symfony/symfony-docs that referenced this issue Sep 23, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

changed repo names to the new ones

Part of symfony/symfony#8295
Ready to be merged as the repositories have already been renamed.

Commits
-------

3a2f335 changed repo names to the new ones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants