Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate Templating/DebuggerInterface #8926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tobion opened this issue Sep 4, 2013 · 0 comments
Closed

Deprecate Templating/DebuggerInterface #8926

Tobion opened this issue Sep 4, 2013 · 0 comments
Labels
Templating

Comments

@Tobion
Copy link
Contributor

Tobion commented Sep 4, 2013

Templating\DebuggerInterface should be deprecated now and removed in 3.0

It doesn't add anything usefull and only complicates integration. It was probably added before there was Psr\LoggerInterface. The abstract Loader should then instead offer a setLogger method which accept a Psr Logger.
@Tobion Tobion mentioned this issue Sep 4, 2013
Merged
2 tasks
fabpot added a commit that referenced this issue Sep 7, 2013
@fabpot
merged branch Tobion/deprecate-debuggerinterface (PR #8929)
08ec911 
This PR was merged into the master branch.

Discussion
----------

[Templating] deprecate DebuggerInterface

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes: deprecated DebuggerInterface and Debugger
| Tests pass?   | yes
| Fixed tickets | #8926
| License       | MIT

- [x] add suggested optional dependency in templating component to Psr log
- [x] remove ProjectTemplateDebugger from tests

Commits
-------

b853438 [Templating] deprecate DebuggerInterface
@Tobion Tobion closed this as completed Sep 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Templating
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tobion