[HttpFoundation] JsonResponse throws an incomprehensible exception if json_encode fails #9903
Labels
Comments
fabpot
added a commit
that referenced
this issue
Dec 31, 2013
…s passed to JsonResponse class (stloyd) This PR was merged into the 2.3 branch. Discussion ---------- [HttpFoundation] Throw proper exception when invalid data is passed to JsonResponse class | Q | A | ------------- | --- | Bug fix? | yes | BC breaks? | no* | Tests pass? | yes | Fixed tickets | #9903 | License | MIT \* as described in mentioned issue, before this PR there was thrown exception `UnexpectedValueException`, which was not correct, but I guess some people trying to hide the bug could use `try {} catch` on it. Commits ------- 38287e7 [HttpFoundation] Throw proper exception when invalid data is passed to JsonResponse class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
JsonResponse::setDatajson_encodeis called then and thenJsonEncode::updateis called to deal with setting up the content.If no JS callback is specified and
json_encodefails -- returnsfalse--Response::setContentthrows anUnexpectedValueExceptionsaying that only strings or objects that have a__toStringmethod are allowed.I ran into this with an invalid UTF8 character that came out of MySQL.
Seems like this could be improved by checking for a
falseresult on thejson_encodecall and usingjson_last_errorto generate a nicer error message.Would that be too detailed for
JsonResponse? Should it be up to the caller to make sure they giveJsonResponse::setDatasomething valid? Even if it's very hard to tell that something may not work?The text was updated successfully, but these errors were encountered: