Routing condition bugfix #10002
Closed
Routing condition bugfix #10002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -167,6 +168,9 @@ protected function parseImport(RouteCollection $collection, \DOMElement $node, $ | |||
| if (null !== $host) { | |||
| $subCollection->setHost($host); | |||
| } | |||
| if(null !== $condition) { | |||
|
Can you add some unit tests as well? |
|
Yes, I will add some tests and correct the formatting! |
…en importing sub routes in the YamlFileLoader.
…en importing sub routes in the XmlFileLoader.
|
Done, does the testing setup makes sense? Don't wanted to duplicate everything. |
|
@fabpot can you please merge this PR? |
|
Thank you @marco-jantke. |
fabpot
added a commit
that referenced
this pull request
Jan 24, 2014
This PR was submitted for the 2.4-dev branch but it was merged into the 2.4 branch instead (closes #10002). Discussion ---------- Routing condition bugfix [Routing] Fixed inheriting of condition to sub routes for xml and yaml configuration. Commits ------- bb7e15e Routing condition bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Routing] Fixed inheriting of condition to sub routes for xml and yaml configuration.