Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Form] Add option to ignore invalid choices #10008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Form] Add option to ignore invalid choices #10008

wants to merge 3 commits into from

Conversation

trsteel88
Copy link
Contributor

Q A
Bug fix? No
New feature? Yes
BC breaks? No
Deprecations? No
Tests pass? Yes
Fixed tickets #9738
License MIT

@jakzal
Copy link
Contributor

jakzal commented Jan 13, 2014

Please include a PR checklist in the description.

@jakzal
Copy link
Contributor

jakzal commented Jan 13, 2014

I'm not convinced this is the best approach to solve #9738. Since any missing fields would be ignored and no error would be raised, user might expect that all his choices were saved.

@trsteel88
Copy link
Contributor Author

@jakzal Yes, but it would only be used in the case where there might be outdated data. Eg, I am using it on a search form where the options can change quite often. Therefore, I don't want an error to be thrown because the search option chosen no longer exists. I still want the form to search with the options which are now available.

PR checklist has been added.

@stof
Copy link
Member

stof commented Jan 13, 2014

I see a real issue here: the option is not applied consistently

@trsteel88
Copy link
Contributor Author

@stof how do you mean? Do you mean for non expanded etc? This would only apply where the field is expanded and allows multiple options.

@stof
Copy link
Member

stof commented Jan 14, 2014

why wouldn't it apply for non-expanded fields allowing multiple selection ? there is no difference between expanded and collapsed rendering of the choice fields as far as the submission processing is concerned (the submitted data looks exactly the same in both cases)

@trsteel88
Copy link
Contributor Author

Ah, yes it should. Sorry, I will fix up tomorrow morning

@trsteel88
Copy link
Contributor Author

@stof that has been updated. Let me know if there is anything else

@webmozart webmozart changed the title add option to ignore invalid choices [Form] Add option to ignore invalid choices Apr 8, 2014
@webmozart
Copy link
Contributor

Hi @trsteel88, thank you for that PR! Unfortunately, #12148 changes quite a bit of the code that is touched by this PR. Hence this needs to be redone when #12148 is merged.

@webmozart webmozart closed this Oct 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants