lazy session start for #6036 without bc #10310
Conversation
|
This is original #10156 without BC |
| * | ||
| * @return boolean | ||
| */ | ||
| private function isExists() |
There was a problem hiding this comment.
isExists is a weird name. You have 2 verbs in this name
There was a problem hiding this comment.
Any suggestions? I think about this name and haven't better name.
There was a problem hiding this comment.
exists, has, isset, isDefined, ... ? It depends on what this method does
|
@stof I rename MockArrayLazySessionStorage to LazyMockArraySessionStorage as you mentioned |
|
I think to close this PR, because of this line in storage: return isset($_COOKIE[session_name()]); Actually hasPreviousSession in Storage must have Request to work like in Request::hasPreviousSession, but this is very big changes and I'm not sure that this will be right changes and now I haven't idea, how to solve this. |
|
Closed, seems will be fixed in 3.0 with broke BC. |
This patch solve problem when session starts after call read method like get, has, count without checking that session isStarted.