[HttpFoundation] Add a way to match a specific scheme in RequestMatcher #10556 #10667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjsaunier
commented
Apr 9, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #10556 |
| License | MIT |
| Doc PR | no |
| @@ -157,4 +185,4 @@ public function matches(Request $request) | |||
| // foreach above or else your check might not be run! | |||
| return count($this->ips) === 0; | |||
| } | |||
| } | |||
| } | |||
| @@ -46,24 +46,49 @@ class RequestMatcher implements RequestMatcherInterface | |||
| private $attributes = array(); | |||
|
|
|||
| /** | |||
| * @var string[] | |||
| */ | |||
| protected $schemes = array(); | |||
| @@ -43,6 +43,25 @@ public function testMethodFixtures() | |||
| ); | |||
| } | |||
|
|
|||
| public function testScheme() | |||
| { | |||
| $httpsRequest = $request = $request = Request::create('', 'get', array(), array(), array(), array('HTTPS' => 'on')); | |||
There was a problem hiding this comment.
Too many variables assigned, here and line below.
|
All are ok for you ? |
| $ips = null, | ||
| array $attributes = array(), | ||
| $schemes = null | ||
| ) |
There was a problem hiding this comment.
|
Property found for PSR-2 ! @fabpot fabbot didnt find the coding standard just above, is what it's expected behavior or not ? |
| $ips = null, | ||
| array $attributes = array(), | ||
| $schemes = null | ||
| ) { |
There was a problem hiding this comment.
should be on one line as before.
|
That can be merge ? |
|
Not before 2.6 which is going to starts in about a month. |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.