[2.3][Process] Add missing docblocks, remove variable declarations #10756
Conversation
romainneutron
commented
Apr 21, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
|
👍 |
| public function __construct(array $arguments = array()) | ||
| { | ||
| $this->arguments = $arguments; | ||
|
|
||
| $this->timeout = 60; |
There was a problem hiding this comment.
Most of these changes are already in 2.4 See https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Process/ProcessBuilder.php
There was a problem hiding this comment.
This is right for the default values of the ProcessBuilder, not for the Process
Docblocks are still missing in version 2.4
Merging in 2.4 should be easy
|
See #9487 |
| * Sets an environment variable | ||
| * | ||
| * @param string $name The variable name | ||
| * @param mixed $value The variable value |
There was a problem hiding this comment.
an environment variable is a string, not a mixed value
There was a problem hiding this comment.
We accept array env vars since #8227
There was a problem hiding this comment.
@romainneutron we just avoid an error by ignoring them, because of the way the inherited environment works. But it does not make any sense to pass an array here. It will still not be part of the environment (it will just erase the previous value set for the same env var, which can be done in a cleaner way with null)
There was a problem hiding this comment.
you're right I'll update this
|
Updated |
…clarations (romainneutron) This PR was merged into the 2.3 branch. Discussion ---------- [2.3][Process] Add missing docblocks, remove variable declarations | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT Commits ------- ff77f24 [Process] Add missing docblocks, remove variable declarations