[Security] Allow overloading ContextListener::refreshUser() #10792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -138,11 +138,12 @@ public function onKernelResponse(FilterResponseEvent $event) | |||
| * | |||
| * @param TokenInterface $token | |||
| * | |||
| * @throws \RuntimeException | |||
There was a problem hiding this comment.
This is duplicate of line 143/144.
|
what is your use case ? We don't change the visibility from private to protected without a valid use case for this, as it means we would now have to maintain BC on this extension point until 3.0 |
|
We have a specialized UserProvider interface, where we pass the user + the token and not just the user to |
|
@fabpot anything we need to do before this can be merged? |
fabpot
added a commit
that referenced
this pull request
Jun 3, 2014
…ser() (lstrojny) This PR was merged into the 2.6-dev branch. Discussion ---------- [Security] Allow overloading ContextListener::refreshUser() Allow overloading refreshUser() for the use case of doing something special with user providers. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n.A. | License | MIT | Doc PR | n.A. Commits ------- b67ed43 Allow overloading ContextListener::refreshUser()
|
Can we merge into 2.4 and 2.5? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overloading refreshUser() for the use case of doing something special with user providers.