Explicitly define the encoding. #10899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1151,7 +1151,7 @@ private function splitStringByWidth($string, $width) | |||
| $line = ''; | |||
| foreach (preg_split('//u', $utf8String) as $char) { | |||
| // test if $char could be appended to current line | |||
| if (mb_strwidth($line.$char) <= $width) { | |||
| if (mb_strwidth($line.$char, $encoding) <= $width) { | |||
There was a problem hiding this comment.
should be utf8, not $encoding, as you are working on the string converted to utf8, not on the string on the original encoding
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
May 14, 2014
This PR was merged into the 2.3 branch. Discussion ---------- Explicitly define the encoding. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Credits for discovering it go to @nicolas-grekas. Cheers! Travis for PHP 5.6 cannot be enabled yet as there's one more test failing. re #10714 #10714 Commits ------- 619ff58 Explicitly define the encoding.
THANK YOU SO MUCH!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credits for discovering it go to @nicolas-grekas. Cheers!
Travis for PHP 5.6 cannot be enabled yet as there's one more test failing.
re #10714 #10714