Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] Fix array notation in the PropertyPath::append() #11117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Validator] Fix array notation in the PropertyPath::append() #11117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70aaa59
[Validator] Add tests for the PropertyPath class.
jakzal Jun 7, 2014
b8558d2
[Validator] Fix array notation support in the PropertyPath::append().
jakzal Jun 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/Symfony/Component/Validator/Tests/Util/PropertyPathTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <[email protected]>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\Validator\Tests\Util;

use Symfony\Component\Validator\Util\PropertyPath;

class PropertyPathTest extends \PHPUnit_Framework_TestCase
{
/**
* @dataProvider provideAppendPaths
*/
public function testAppend($basePath, $subPath, $expectedPath, $message)
{
$this->assertSame($expectedPath, PropertyPath::append($basePath, $subPath), $message);
}

public function provideAppendPaths()
{
return array(
array('foo', '', 'foo', 'It returns the basePath if subPath is empty'),
array('', 'bar', 'bar', 'It returns the subPath if basePath is empty'),
array('foo', 'bar', 'foo.bar', 'It append the subPath to the basePath'),
array('foo', '[bar]', 'foo[bar]', 'It does not include the dot separator if subPath uses the array notation')
);
}
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Validator/Util/PropertyPath.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class PropertyPath
public static function append($basePath, $subPath)
{
if ('' !== (string) $subPath) {
if ('[' === $subPath{1}) {
if ('[' === $subPath{0}) {
return $basePath.$subPath;
}

Expand Down