Use PSR-4 everywhere instead of PSR-0 #11199
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis failure is now json-related in the latest 5.4/5.5/5.6 releases. Should not block this PR. |
| @@ -116,6 +116,11 @@ private function getClassCandidates($class) | |||
| $classes = array_merge($classes, $this->findClassInPath($path, $class)); | |||
| } | |||
| } | |||
| foreach ($function[0]->getPrefixesPsr4() as $prefix => $paths) { | |||
There was a problem hiding this comment.
getPrefixesPsr4 only exists in the Composer ClassLoader, not in the Symfony one
There was a problem hiding this comment.
Oh right I missed the second part of the if above, will fix :)
|
👍 |
1 similar comment
|
👍 |
|
Needs to be updated for VarDumper component and DebugBundle. |
|
Now that PSR-0 is considered deprecated, it's maybe a good time to perform the switch. What do you think? |
|
If it's good for everyone I guess I'll update it for the new components and it can go in 2.7 and up. |
|
👍 |
|
Closing in favor of #12466 against 2.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes and replaces #11190 + psr-4 support for ClassNotFoundFatalErrorHandler (not sure if this is considered as a new feature, it's kinda trivial)