[Serializer] Added a test for decoding xml with whitespaces #11233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should probably be done in the branch where the BC was introduced. Edited: looks like it's only in master. |
| $this->assertEquals($expected, $this->encoder->decode($xml, 'xml')); | ||
| $this->assertEquals( | ||
| $expected, | ||
| $this->encoder->decode($xml, 'xml', array('xml_decode_ignore_white_space' => true)) |
There was a problem hiding this comment.
if you require passign an option to achieve the same result, it is not BC
|
The commit 466a3d7 was reverting a BC break |
|
so I'm -1 for this pR, at least in its current form. It implements a new feature, but reintroduces the previous BC break by default |
|
I missed the fact that 466a3d7 reverted a BC break. Whitespaces were previously ignored so it works as intended. I've kept the test because none of them contains whitespaces despite the Cdata one (which was part of the confusion). |
|
👍 now that it only adds an extra test |
|
👍 |
|
Thank you @florianv. |
fabpot
added a commit
that referenced
this pull request
Jul 4, 2014
…ces (florianv) This PR was merged into the 2.6-dev branch. Discussion ---------- [Serializer] Added a test for decoding xml with whitespaces | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The PR 466a3d7 introduced a BC break because white spaces were previously decoded as text nodes. So this PR reverts it and adds a context option to configure it. Commits ------- f5bf45e [Serializer] Added a test for decoding xml with whitespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR 466a3d7 introduced a BC break because white spaces were previously decoded as text nodes.
So this PR reverts it and adds a context option to configure it.