Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] Enabled translation:update for app folder #11254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rdohms
Copy link
Contributor

@rdohms rdohms commented Jun 30, 2014

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

Changed the Bundle requirement to allow the command to also be executed for the app/Resources
folder of the application, which currently cannot be achieved.

This patch should also work for previous versions.

@rdohms
Copy link
Contributor Author

rdohms commented Jun 30, 2014

Humm, not sure what triggered the broken test, seems like a Travis config bug as it says The command "false" exited with 1.

@stof
Copy link
Member

stof commented Jun 30, 2014

this is because we have || false at the end of the parallel command (which actually does not make sense and should be removed). this means that the testsuite failed actually.
However, I indeed don't see the failure. This is weird

@jakzal
Copy link
Contributor

jakzal commented Jun 30, 2014

Console tests crashed with a segmentation fault.

@rdohms
Copy link
Contributor Author

rdohms commented Jun 30, 2014

@jakzal so that has nothing to do with the FrameworkBundle i'm guessing?

@jakzal
Copy link
Contributor

jakzal commented Jun 30, 2014

@rdohms it shouldn't. I'll restart the build and keep an eye on them.

@jakzal
Copy link
Contributor

jakzal commented Jun 30, 2014

Aaand it pased... looks like one of the accidental failures :(

@rdohms
Copy link
Contributor Author

rdohms commented Jul 10, 2014

Any word on merging this? @fapot?

When new translation strings are found it can automatically add a prefix to the translation
message.

<info>php %command.full_name% --dump-messages en AcmeBundle</info>
<info>php %command.full_name% --force --prefix="new_" fr AcmeBundle</info>
<info>php %command.full_name% --dump-messages en</info>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a small text before these command to explicitely make a difference between messages coming from a bundle and messages coming from app?

@fabpot
Copy link
Member

fabpot commented Jul 25, 2014

Besides my small comments, that looks good to me.

@rdohms
Copy link
Contributor Author

rdohms commented Jul 25, 2014

@fabpot thanks, i'm on them

@rdohms
Copy link
Contributor Author

rdohms commented Jul 25, 2014

Done. Should I rebase into a single commit?

@fabpot
Copy link
Member

fabpot commented Jul 25, 2014

👍

You can squash the commits into one, but it's going to be done automatically anyway when merging.

@rdohms
Copy link
Contributor Author

rdohms commented Jul 25, 2014

opps, messed up, let me fix this

Changed the Bundle requirement to allow the command to also be executed for the app/Resources
folder of the application, which currently cannot be achieved.
@rdohms
Copy link
Contributor Author

rdohms commented Jul 25, 2014

Rebased and squashed.

@stof
Copy link
Member

stof commented Aug 14, 2014

👍

@fabpot
Copy link
Member

fabpot commented Aug 27, 2014

merging into master as this is a new feature.

@fabpot
Copy link
Member

fabpot commented Aug 27, 2014

Thank you @rdohms.

@fabpot fabpot closed this in 2a8268c Aug 27, 2014
@rdohms
Copy link
Contributor Author

rdohms commented Aug 27, 2014

This means 2.6 right?
On Aug 27, 2014 2:59 PM, "Fabien Potencier" [email protected]
wrote:

Closed #11254 #11254 via 2a8268c
2a8268c
.


Reply to this email directly or view it on GitHub
#11254 (comment).

@stof
Copy link
Member

stof commented Aug 27, 2014

@rdohms yes

@rdohms
Copy link
Contributor Author

rdohms commented Aug 27, 2014

Great! Thanks guys looking forward to it.
On Aug 27, 2014 3:25 PM, "Christophe Coevoet" [email protected]
wrote:

@rdohms https://github.com/rdohms yes


Reply to this email directly or view it on GitHub
#11254 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants