[FrameworkBundle] Enabled translation:update for app folder #11254
Conversation
|
Humm, not sure what triggered the broken test, seems like a Travis config bug as it says |
|
this is because we have |
|
Console tests crashed with a segmentation fault. |
|
@jakzal so that has nothing to do with the FrameworkBundle i'm guessing? |
|
@rdohms it shouldn't. I'll restart the build and keep an eye on them. |
|
Aaand it pased... looks like one of the accidental failures :( |
|
Any word on merging this? @fapot? |
| When new translation strings are found it can automatically add a prefix to the translation | ||
| message. | ||
|
|
||
| <info>php %command.full_name% --dump-messages en AcmeBundle</info> | ||
| <info>php %command.full_name% --force --prefix="new_" fr AcmeBundle</info> | ||
| <info>php %command.full_name% --dump-messages en</info> |
There was a problem hiding this comment.
Can you add a small text before these command to explicitely make a difference between messages coming from a bundle and messages coming from app?
|
Besides my small comments, that looks good to me. |
|
@fabpot thanks, i'm on them |
|
Done. Should I rebase into a single commit? |
|
👍 You can squash the commits into one, but it's going to be done automatically anyway when merging. |
|
opps, messed up, let me fix this |
Changed the Bundle requirement to allow the command to also be executed for the app/Resources folder of the application, which currently cannot be achieved.
|
Rebased and squashed. |
|
👍 |
|
merging into master as this is a new feature. |
|
Thank you @rdohms. |
|
This means 2.6 right?
|
|
@rdohms yes |
|
Great! Thanks guys looking forward to it.
|
Changed the Bundle requirement to allow the command to also be executed for the app/Resources
folder of the application, which currently cannot be achieved.
This patch should also work for previous versions.