[DX] Added line feed to container alias description (text descriptor) #11305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -273,7 +273,7 @@ protected function describeContainerDefinition(Definition $definition, array $op | |||
| */ | |||
| protected function describeContainerAlias(Alias $alias, array $options = array()) | |||
| { | |||
| $this->writeText(sprintf('This service is an alias for the service <info>%s</info>', (string) $alias), $options); | |||
| $this->writeText(sprintf("This service is an alias for the service <info>%s</info>\n", (string) $alias), $options); | |||
There was a problem hiding this comment.
Wouldn't it be better to use the system independent PHP_EOL constant instead of \n?
There was a problem hiding this comment.
The whole file is using \n, see lines 60, 94, 110, 128...
There was a problem hiding this comment.
There's only one use of PHP_EOL that's not testing related in the whole symfony/symfony repo. I don't remember why but I think that was a choice made by the the core at some point.
|
I think Travis failure is not related to my PR... Tests are passing :) |
|
Thank you @zefrog. |
fabpot
added a commit
that referenced
this pull request
Jul 25, 2014
…t descriptor) (Maxime Douailin) This PR was merged into the 2.6-dev branch. Discussion ---------- [DX] Added line feed to container alias description (text descriptor) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | N/A This PR just adds a line feed at the end of the alias service description delivered by the ContainerDebugCommand. Tests are passing because expected outputs are trimmed before comparison (which IMO is not a really good thing, but hey...) Commits ------- 13c011c Added line feed to container alias description (text descriptor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds a line feed at the end of the alias service description delivered by the ContainerDebugCommand. Tests are passing because expected outputs are trimmed before comparison (which IMO is not a really good thing, but hey...)