[DX] Ability to authentication a User directly #11320
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <[email protected]> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Bundle\SecurityBundle\Security\Http\RememberMe; | ||
|
|
||
| use Symfony\Component\DependencyInjection\ContainerInterface; | ||
| use Symfony\Component\Security\Http\RememberMe\RememberMeServicesInterface; | ||
| use Symfony\Component\Security\Http\RememberMe\RememberMeServicesResolverInterface; | ||
|
|
||
| class RememberMeServicesResolver implements RememberMeServicesResolverInterface | ||
| { | ||
| /** | ||
| * @var \Symfony\Component\DependencyInjection\ContainerInterface | ||
| */ | ||
| private $serviceContainer; | ||
|
|
||
| /** | ||
| * @param ContainerInterface $serviceContainer | ||
| */ | ||
| public function __construct(ContainerInterface $serviceContainer) | ||
| { | ||
| $this->serviceContainer = $serviceContainer; | ||
| } | ||
|
|
||
| /** | ||
| * @param $providerKey | ||
| * @return null|RememberMeServicesInterface | ||
| */ | ||
| public function resolve($providerKey) | ||
| { | ||
| $rememberMeServices = null; | ||
| if ($this->serviceContainer->has('security.authentication.rememberme.services.persistent.'.$providerKey)) { | ||
| $rememberMeServices = $this->serviceContainer->get('security.authentication.rememberme.services.persistent.'.$providerKey); | ||
| } elseif ($this->serviceContainer->has('security.authentication.rememberme.services.simplehash.'.$providerKey)) { | ||
| $rememberMeServices = $this->serviceContainer->get('security.authentication.rememberme.services.simplehash.'.$providerKey); | ||
| } | ||
|
|
||
| if ($rememberMeServices instanceof RememberMeServicesInterface) { | ||
| return $rememberMeServices; | ||
| } | ||
|
|
||
| return; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <[email protected]> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\LoginManagerBundle\Controller; | ||
|
|
||
| use Symfony\Component\HttpFoundation\Response; | ||
| use Symfony\Component\DependencyInjection\ContainerAware; | ||
|
|
||
| class LoginController extends ContainerAware | ||
| { | ||
| public function loginAction() | ||
| { | ||
| $user = $this->container->get('security.user.provider.concrete.in_memory')->loadUserByUsername('norzechowicz'); | ||
| $this->container->get('security.login_manager')->loginUser('secured_area', $user); | ||
|
|
||
| return new Response(); | ||
| } | ||
|
|
||
| public function loginCheckAction() | ||
| { | ||
| return new Response('', 400); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <[email protected]> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\LoginManagerBundle\Controller; | ||
|
|
||
| use Symfony\Component\HttpFoundation\Response; | ||
| use Symfony\Component\DependencyInjection\ContainerAware; | ||
|
|
||
| class SecuredController extends ContainerAware | ||
| { | ||
| public function indexAction() | ||
| { | ||
| return new Response("Secured area"); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <[email protected]> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\LoginManagerBundle; | ||
|
|
||
| use Symfony\Component\HttpKernel\Bundle\Bundle; | ||
|
|
||
| class LoginManagerBundle extends Bundle | ||
| { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| login: | ||
| path: /login | ||
| defaults: { _controller: LoginManagerBundle:Login:login } | ||
|
|
||
| login_check: | ||
| path: /login_check | ||
| defaults: { _controller: LoginManagerBundle:Login:loginCheck } | ||
|
|
||
| secured_index: | ||
| path: /secured/index | ||
| defaults: { _controller: LoginManagerBundle:Secured:index } | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <[email protected]> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Bundle\SecurityBundle\Tests\Functional; | ||
|
|
||
| /** | ||
| * @group functional | ||
| */ | ||
| class LoginManagerTestCase extends WebTestCase | ||
| { | ||
| public function testLoginUserInController() | ||
| { | ||
| $client = $this->createClient(array('test_case' => 'LoginManager')); | ||
|
|
||
| // Avoid to follow redirects. If we follow this redirect, the user | ||
| // will be logged in automatically | ||
| $client->setMaxRedirects(-1); | ||
| $client->request('GET', '/secured/index'); | ||
| $this->assertRedirect($client->getResponse(), '/login'); | ||
|
|
||
| // Access to '/login' route to login the user automatically | ||
| $client->request('GET', '/login'); | ||
| $client->request('GET', '/secured/index'); | ||
| $this->assertEquals('Secured area', $client->getResponse()->getContent()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <?php | ||
|
|
||
| return array( | ||
| new Symfony\Bundle\FrameworkBundle\FrameworkBundle(), | ||
| new Symfony\Bundle\SecurityBundle\SecurityBundle(), | ||
| new Symfony\Bundle\TwigBundle\TwigBundle(), | ||
| new Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\LoginManagerBundle\LoginManagerBundle(), | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| imports: | ||
| - { resource: ./../config/default.yml } | ||
|
|
||
| security: | ||
| encoders: | ||
| Symfony\Component\Security\Core\User\User: plaintext | ||
|
|
||
| providers: | ||
| in_memory: | ||
| memory: | ||
| users: | ||
| norzechowicz: { password: test, roles: [ROLE_USER] } | ||
|
|
||
| firewalls: | ||
| secured_area: | ||
| pattern: ^/ | ||
| form_login: | ||
| check_path: /login_check | ||
| default_target_path: /secured/index | ||
| anonymous: ~ | ||
|
|
||
| access_control: | ||
| - { path: ^/login$, roles: IS_AUTHENTICATED_ANONYMOUSLY } | ||
| - { path: .*, roles: ROLE_USER } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| _csrf_form_login_bundle: | ||
| resource: @LoginManagerBundle/Resources/config/routing.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <[email protected]> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\Security\Http\Login; | ||
|
|
||
| use Symfony\Component\HttpFoundation\RequestStack; | ||
| use Symfony\Component\HttpFoundation\Response; | ||
| use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken; | ||
| use Symfony\Component\Security\Core\SecurityContextInterface; | ||
| use Symfony\Component\Security\Core\User\UserCheckerInterface; | ||
| use Symfony\Component\Security\Core\User\UserInterface; | ||
| use Symfony\Component\Security\Http\RememberMe\RememberMeServicesResolverInterface; | ||
| use Symfony\Component\Security\Http\Session\SessionAuthenticationStrategyInterface; | ||
| use Symfony\Component\Security\Core\Exception\AuthenticationException; | ||
|
|
||
| class LoginManager | ||
| { | ||
| /** | ||
| * @var SecurityContextInterface | ||
| */ | ||
| private $securityContext; | ||
|
|
||
| /** | ||
| * @var UserCheckerInterface | ||
| */ | ||
| private $userChecker; | ||
|
|
||
| /** | ||
| * @var RequestStack | ||
| */ | ||
| private $requestStack; | ||
|
|
||
| /** | ||
| * @var SessionAuthenticationStrategyInterface | ||
| */ | ||
| private $sessionAuthenticationStrategy; | ||
|
|
||
| /** | ||
|
|
||
| * @var RememberMeServicesResolverInterface | ||
| */ | ||
| private $rememberMeServicesResolver; | ||
|
|
||
| /** | ||
| * @param SecurityContextInterface $securityContext | ||
| * @param UserCheckerInterface $userChecker | ||
| * @param RequestStack $requestStack | ||
| * @param SessionAuthenticationStrategyInterface $sessionAuthenticationStrategy | ||
| * @param RememberMeServicesResolverInterface $rememberMeServicesResolver | ||
| */ | ||
| public function __construct(SecurityContextInterface $securityContext, UserCheckerInterface $userChecker, RequestStack $requestStack, SessionAuthenticationStrategyInterface $sessionAuthenticationStrategy, RememberMeServicesResolverInterface $rememberMeServicesResolver) | ||
| { | ||
| $this->securityContext = $securityContext; | ||
| $this->userChecker = $userChecker; | ||
| $this->requestStack = $requestStack; | ||
| $this->sessionAuthenticationStrategy = $sessionAuthenticationStrategy; | ||
| $this->rememberMeServicesResolver = $rememberMeServicesResolver; | ||
| } | ||
|
|
||
| /** | ||
| * @param $firewallName | ||
| * @param UserInterface $user | ||
| * @param Response $response | ||
| */ | ||
| public function loginUser($firewallName, UserInterface $user, Response $response = null) | ||
| { | ||
| $this->userChecker->checkPreAuth($user); | ||
| $this->userChecker->checkPostAuth($user); | ||
|
There was a problem hiding this comment. Shouldn't the method |
||
| $token = $this->createToken($firewallName, $user); | ||
|
There was a problem hiding this comment. Shouldn't we check if the token has been authenticated? if (!$token->isAuthenticated()) {
throw new AuthenticationException("Unauthenticated token.");
} |
||
|
|
||
| if (!$token->isAuthenticated()) { | ||
| throw new AuthenticationException("Unauthenticated token"); | ||
| } | ||
|
|
||
| $request = $this->requestStack->getMasterRequest(); | ||
| if (null !== $request) { | ||
| $this->sessionAuthenticationStrategy->onAuthentication($request, $token); | ||
|
|
||
| if (null !== $response) { | ||
|
There was a problem hiding this comment. This could let you remove one level of indentation: if (null !== $response && ($rememberMeServices = $this->rememberMeServicesResolver->resolve($firewallName)) { |
||
| $rememberMeServices = $this->rememberMeServicesResolver->resolve($firewallName); | ||
|
|
||
| if (null !== $rememberMeServices) { | ||
| $rememberMeServices->loginSuccess($request, $response, $token); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| $this->securityContext->setToken($token); | ||
| } | ||
|
|
||
| /** | ||
| * @param $firewall | ||
| * @param UserInterface $user | ||
| * @return UsernamePasswordToken | ||
| */ | ||
| protected function createToken($firewall, UserInterface $user) | ||
| { | ||
| return new UsernamePasswordToken($user, null, $firewall, $user->getRoles()); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <?php | ||
|
|
||
| namespace Symfony\Component\Security\Http\RememberMe; | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <[email protected]> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| interface RememberMeServicesResolverInterface | ||
| { | ||
| /** | ||
| * @param $providerKey | ||
| * @return null|RememberMeServicesInterface | ||
| */ | ||
| public function resolve($providerKey); | ||
|
There was a problem hiding this comment. I don't see the need for an interface. There was a problem hiding this comment. Are you sure about that? There was a problem hiding this comment. For And if you'd like to replace the I can see it either way, but I don't think we really lose anything with removing the interface. |
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly these services are marked private. We also have (had?) this problem in the FOSUserBundle.