[HttpFoundation] Update QUERY_STRING when overrideGlobals #11408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yguedidi
commented
Jul 17, 2014
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
ping @fabpot |
| @@ -479,6 +479,8 @@ public function __toString() | |||
| */ | |||
| public function overrideGlobals() | |||
| { | |||
| $this->server->set('QUERY_STRING', static::normalizeQueryString(http_build_query($this->query->all(), null, '&'))); | |||
There was a problem hiding this comment.
should probably be $_SERVER['QUERY_STRING'] = static::... instead (and moved after the main $_SERVER assignation). But I don't see why this would be needed.
There was a problem hiding this comment.
A use case is when you want to get the current URI without some GET parameters:
$request->query->remove('nonce');
$redirectUri = $request->getUri();I code it like this at the first position because getUri() uses getQueryString() that gets the query string from $this->server.
There was a problem hiding this comment.
@fabpot does this need something else?
|
👍 |
2 similar comments
|
👍 |
|
👍 |
|
Thanks for fixing this bug @yguedidi. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 13, 2014
…(yguedidi) This PR was merged into the 2.3 branch. Discussion ---------- [HttpFoundation] Update QUERY_STRING when overrideGlobals | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 777666f [HttpFoundation] Update QUERY_STRING when overrideGlobals
|
@nicolas-grekas You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.