Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Translation] made XliffFileDumper support CDATA section. #11512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

hhamon
Copy link
Contributor

@hhamon hhamon commented Jul 29, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? maybe
Deprecations? no
Tests pass? yes
Fixed tickets #11256
License MIT

@hhamon
Copy link
Contributor Author

hhamon commented Jul 29, 2014

Not sure if this commit is legit but when you have CDATA sections in your Xliff file, they're removed by the translation:update command and special characters like < and > are converted to &lt; and gt;. Shall we support the fact that translations can have CDATA contents?

@hhamon hhamon closed this Jul 29, 2014
@hhamon hhamon deleted the translator-xliff-dumper-cdata branch July 29, 2014 19:38
fabpot added a commit that referenced this pull request Aug 1, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Make builds green again

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This PR rolls back changes made to the fixture and generated files in e9022ad (#11512).

Commits
-------

88b4e70 [DependencyInjection] Roll back changes made to generated files.
f89811d [Console] Roll back changes made to fixture files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants