Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Form] fix whitespace in Twig form template #11550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2014
Merged

Conversation

craue
Copy link
Contributor

@craue craue commented Aug 2, 2014

Q A
Bug fix? kind of (after updating from 2.3.17 to 2.3.18, some of my tests were broken because of this)
New feature? no
BC breaks? no
Deprecations? no
Tests pass? they should, let's see what Travis has to say...
Fixed tickets --
License MIT
Doc PR --

This fixes some whitespace rendering.

after merging #11386:

<input type="text" id="myfield" name="myfield"     value="blah" />

before merging #11386 and with this PR again:

<input type="text" id="myfield" name="myfield" value="blah" />

@craue craue changed the title [Form] add missing whitespace control modifier in Twig form template [Form] fix whitespace in Twig form template Aug 2, 2014
@Tobion
Copy link
Contributor

Tobion commented Aug 3, 2014

I don't see where the extra spaces come from in the old version?

@craue
Copy link
Contributor Author

craue commented Aug 4, 2014

4 of them are those before the {% for, but only replacing it by {%- for made some tests fail, thus the other changes.

@Tobion
Copy link
Contributor

Tobion commented Aug 4, 2014

👍

1 similar comment
@fabpot
Copy link
Member

fabpot commented Aug 5, 2014

👍

@fabpot
Copy link
Member

fabpot commented Aug 5, 2014

Thank you @craue.

@fabpot fabpot merged commit 8504d02 into symfony:2.3 Aug 5, 2014
fabpot added a commit that referenced this pull request Aug 5, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

[Form] fix whitespace in Twig form template

| Q             | A
| ------------- | ---
| Bug fix?      | kind of (after updating from 2.3.17 to 2.3.18, some of my tests were broken because of this)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | they should, let's see what Travis has to say...
| Fixed tickets | --
| License       | MIT
| Doc PR        | --

This fixes some whitespace rendering.

after merging #11386:
```html
<input type="text" id="myfield" name="myfield"     value="blah" />
```

before merging #11386 and with this PR again:
```html
<input type="text" id="myfield" name="myfield" value="blah" />
```

Commits
-------

8504d02 fixed whitespace in Twig form template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants