[Validator] Convert objects to string in comparison validators #11559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| { | ||
| if ($prettyDateTime && $value instanceof \DateTime) { | ||
| if (($format & self::PRETTY_DATE) && $value instanceof \DateTime) { |
There was a problem hiding this comment.
should this not also support http://php.net/manual/de/class.datetimeinterface.php from php 5.5
There was a problem hiding this comment.
adding the DateTimeInterface check is indeed a good idea (but not strictly required by this bugfix though, it is a separate one)
|
👍 |
|
Thanks @webmozart. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 13, 2014
…tors (webmozart) This PR was merged into the 2.3 branch. Discussion ---------- [Validator] Convert objects to string in comparison validators | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - In the [latest merge from 2.3 into 2.4](/symfony/symfony/commit/3bed1b7988e94a897a64c6a2ad3bf70bde9005c1), the changes from 6cf5e08 in 2.4 got lost. This PR brings back these changes and backports them to 2.3. The change is BC, because the former value `true` of the `$prettyDateTime` will be cast to `1`, which corresponds to the `PRETTY_DATE` format constant. Commits ------- 273671e [Validator] Convert objects to string in comparison validators. Reapplies 6cf5e08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest merge from 2.3 into 2.4, the changes from 6cf5e08 in 2.4 got lost. This PR brings back these changes and backports them to 2.3.
The change is BC, because the former value
trueof the$prettyDateTimewill be cast to1, which corresponds to thePRETTY_DATEformat constant.