[DomCrawler] fix the axes handling in a bc way #11624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix in symfony#11548 for handling XPath axes was not backward compatible. In previous Symfony versions the Crawler handled nodes by holding a "fake root node". This must be taken into account when evaluating (relativizing) XPath expressions.
| } elseif ('/' === $expression[0]) { | ||
| $expression = 'self::'.substr($expression, 2); | ||
| } elseif (0 === strpos($expression, 'child::')) { | ||
| $expression = 'self::'.substr($expression, 7); |
There was a problem hiding this comment.
are you sure about this normalization (please run your new tests against a 2.3.13 codebase to ensure it works the same)
There was a problem hiding this comment.
Yes, child::foo is equivalent to ./foo (which is covered with a similar test in testFilterXpathComplexQueries()).
I applied the tests on Symfony 2.3.13 in this branch. The only tests being skipped are the ones affecting the fake root node and the namespace axes. The results are here.
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Aug 12, 2014
|
👍 |
1 similar comment
|
👍 |
|
Thanks for fixing this bug @xabbuh. |
stof
added a commit
that referenced
this pull request
Aug 19, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [DomCrawler] fix the axes handling in a bc way | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11503 | License | MIT | Doc PR | The previous fix in #11548 for handling XPath axes was not backward compatible. In previous Symfony versions the Crawler handled nodes by holding a "fake root node". This must be taken into account when evaluating (relativizing) XPath expressions. Commits ------- d26040f [DomCrawler] fix the axes handling in a bc way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix in #11548 for handling XPath axes was not backward compatible. In previous Symfony versions the Crawler handled nodes by holding a "fake root node". This must be taken into account when evaluating (relativizing) XPath expressions.