fix dependencies on HttpFoundation component #11637
Conversation
| @@ -18,7 +18,7 @@ | |||
| "require": { | |||
| "php": ">=5.3.3", | |||
| "symfony/twig-bridge": "~2.5", | |||
| "symfony/http-kernel": "~2.1" | |||
| "symfony/http-kernel": "~2.5" | |||
There was a problem hiding this comment.
I don't understand why you bump the HttpKernel dependency here, if your issue is with HttpFoundation
There was a problem hiding this comment.
Response::closeOutputBuffers() is called in the ExceptionController. I don't know why the HttpFoundation component isn't required here. But we then need to increase the HttpKernel dependency to indirectly receive the needed version of the HttpFoundation.
I would be more happy with requiring the HttpFoundation component here explicitly. If you agree, I'll add it and revert the change to the HttpKernel dependency.
There was a problem hiding this comment.
well, until now, we were happy with the indirect dependency. But if we need HttpFoundation 2.5, the right way is to require it explicitly, not to bump another dependency relying on the fact it has also bumped its own dependency
There was a problem hiding this comment.
I see. Changed it accordingly.
The closeOutputBuffers() method was added to the Response class of the HttpFoundation in Symfony 2.5. Therefore, parts that are calling this method must depend on symfony/http-foundation 2.5 or higher.
|
👍 |
1 similar comment
|
👍 |
|
Thank you @xabbuh. |
This PR was merged into the 2.5 branch. Discussion ---------- fix dependencies on HttpFoundation component | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11636 | License | MIT | Doc PR | The ``closeOutputBuffers()`` method was added to the ``Response`` class of the HttpFoundation in Symfony 2.5. Therefore, parts that are calling this method must depend on ``symfony/http-foundation`` 2.5 or higher. Commits ------- fe2f007 fix dependencies on HttpFoundation component
The
closeOutputBuffers()method was added to theResponseclass of the HttpFoundation in Symfony 2.5. Therefore, parts that are calling this method must depend onsymfony/http-foundation2.5 or higher.