[WebProfilerBundle ] Fix toolbar vertical alignment #11641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you paste a screenshot before/after ? |
|
Before: After: |
|
👍 |
|
thx @stof |
|
Could you please rebase this PR on branch 2.3? 👍 from me. |
|
@nicolas-grekas why not just doing it with the GH tool when merging ? If @blaugueux does the rebase, it will also require recreating another PR to change the target. |
|
Right! I'll do that |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 13, 2014
…ueux) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #11641). Discussion ---------- [WebProfilerBundle ] Fix toolbar vertical alignment | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Fix the vertical alignment of texts in the toolbar. This issue appears when a reset css contain ```vertical-align: top/bottom/middle;``` Commits ------- 65220e7 Fix toolbar vertical alignment.
|
Closed via 48b150a |
|
Thx @nicolas-grekas :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the vertical alignment of texts in the toolbar.
This issue appears when a reset css contain
vertical-align: top/bottom/middle;