[Validators] Fixed failing tests requiring ICU 52.1 which are skipped otherwise #11695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened against the wrong branch: This should be merged into 2.3. |
|
👍 |
|
👍 |
1 similar comment
|
👍 |
webmozart
added a commit
that referenced
this pull request
Aug 19, 2014
…are skipped otherwise (webmozart) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #11695). Discussion ---------- [Validators] Fixed failing tests requiring ICU 52.1 which are skipped otherwise | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I just ran the tests with ICU 52.1 installed and noticed that a few of them failed. This PR fixes these tests. Commits ------- 5440ed5 [Validators] Fixed failing tests requiring ICU 52.1 which are skipped otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just ran the tests with ICU 52.1 installed and noticed that a few of them failed. This PR fixes these tests.