[Validator] Fixed time constraint (support formats H, H:i and H:i:s) #11821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bes89 please rebase your PR as it conflicts with the current state of the master branch |
…y, with minutes and with minutes and seconds | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | -
|
It seems to be good now. |
|
|
||
| namespace Symfony\Component\Validator\Exception; | ||
|
|
||
| class InvalidConfigurationException extends InvalidArgumentException |
There was a problem hiding this comment.
This class is not needed. There is already a https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/Exception/ConstraintDefinitionException.php
There was a problem hiding this comment.
|
@bes89 when rebasing, you need to force the push to your branch instead of merging the remote branch. Otherwise, it duplicates the commits in the history |
|
I think we should focus our efforts on #11925. Let's keep Date, DateTime and Time as they are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reactivated PR, see #9163