Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[TwigBridge] fix DumpExtension tests #12142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 5, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Make test compatible with the changes from #12125.

Make test compatible with the changes from symfony#12125.
@stof
Copy link
Member

stof commented Oct 5, 2014

👍

@symfony/mergers given that volatile tests have been fixed, the Travis status is reliable again, so we need to loose the habit of merging with a red status

@xabbuh
Copy link
Member Author

xabbuh commented Oct 5, 2014

@stof We had some broken tests during the last week which made all Travis builds fail. After this pull request, builds for pending PRs should probably be executed again to get more reliable results (there are still two or three volatile tests which fail from time to time).

@Tobion
Copy link
Contributor

Tobion commented Oct 5, 2014

👍

@xabbuh
Copy link
Member Author

xabbuh commented Oct 5, 2014

Hm, the components tests fail.

@stof
Copy link
Member

stof commented Oct 5, 2014

looks like SecurityBundle is missing a dependency on Console somewhere

@xabbuh
Copy link
Member Author

xabbuh commented Oct 5, 2014

Yes, coming from the test for the SetAclCommand. But the FormHelperDivLayoutTest is failing too.

The `SetAclCommandTest` indirectly requires the Symfony Console
component.
@stof
Copy link
Member

stof commented Oct 5, 2014

for some reason, the 2.5.x-dev branch of the form component has been installed rather than using the 2.6-dev version, and the test expectation has been changed in master in #12050

@xabbuh
Copy link
Member Author

xabbuh commented Oct 5, 2014

The version constraint actually is 2.5.*. So, 2.6-dev is not allowed.

@stof
Copy link
Member

stof commented Oct 5, 2014

in the master branch of Symfony ? WTF

@xabbuh
Copy link
Member Author

xabbuh commented Oct 5, 2014

I updated it to ~2.6@dev. Should probably succeed now.

@xabbuh
Copy link
Member Author

xabbuh commented Oct 5, 2014

Hm, the version constraint was changed in a4217c3 in the 2.5 branch. Though I'm not sure about the reason for it.

@xabbuh
Copy link
Member Author

xabbuh commented Oct 5, 2014

The build finally ran successfully.

@stof
Copy link
Member

stof commented Oct 5, 2014

Hm, the version constraint was changed in a4217c3 in the 2.5 branch. Though I'm not sure about the reason for it.

for the same reason: to avoid that the 2.5 branch receives the form expectation of 2.6 😄

@nicolas-grekas
Copy link
Member

Thanks for the patch. This will need a rebase once #12145 is merged (or the other way around): I renamed Sfjs.dump to Sfdump

@fabpot
Copy link
Member

fabpot commented Oct 6, 2014

Thank you @xabbuh.

@fabpot fabpot closed this in 966c586 Oct 6, 2014
@xabbuh xabbuh deleted the fix-twig-bridge-tests branch October 6, 2014 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants