enforce memcached version to be 2.1.0 #12297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b64477b to
63dfdad
Compare
|
It would also be good to detect the Memcached version in the test and skip them when we cannot mock the class, to avoid false failures for people testing locally |
63dfdad to
9761c5b
Compare
The signature of the `Memcached::get()` method changed with 2.2.0. Therefore, tests fail in Symfony when mocking `Memcached` in the `MemcachedSessionHandlerTest` of the HttpFoundation component (see also php-memcached-dev/php-memcached#126 and https://bugs.php.net/bug.php?id=66331).
9761c5b to
2ac5c86
Compare
|
That's indeed a good idea. I added it. |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Oct 23, 2014
This PR was merged into the 2.3 branch. Discussion ---------- enforce memcached version to be 2.1.0 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9797 | License | MIT | Doc PR | The signature of the `Memcached::get()` method changed with 2.2.0. Therefore, tests fail in Symfony when mocking `Memcached` in the `MemcachedSessionHandlerTest` of the HttpFoundation component (see also php-memcached-dev/php-memcached#126 and https://bugs.php.net/bug.php?id=66331). Commits ------- 2ac5c86 enforce memcached version to be 2.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of the
Memcached::get()method changed with 2.2.0.Therefore, tests fail in Symfony when mocking
Memcachedin theMemcachedSessionHandlerTestof the HttpFoundation component (seealso php-memcached-dev/php-memcached#126 and
https://bugs.php.net/bug.php?id=66331).