[WIP][DX] Better exception page #12363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woh, the before and after is amazing! Great idea - especially the Twig inclusion. |
| @@ -1,6 +1,12 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| 2.6.0 | |||
There was a problem hiding this comment.
It's going to be in 2.7. 2.6 is closed for new features.
|
@hason It looks awesome. In the after screenshot there is a line break in the PHP code line 4701. I would prefer if you make the area to scroll instead of the line break. |
…onProcessor into the bundles
| { | ||
| protected $regexString = '"[^"\\\\]*?(?:\\\\.[^"\\\\]*?)*?"|\'[^\'\\\\]*?(?:\\\\.[^\'\\\\]*?)*?\''; | ||
| protected $regexTags; | ||
| protected $regex; |
| @@ -17,7 +17,7 @@ | |||
| <a id="traces-link-{{ position }}"></a> | |||
| <ol class="traces list-exception" id="traces-{{ position }}" style="display: {{ 0 == count ? 'block' : 'none' }}"> | |||
There was a problem hiding this comment.
Can you use the same twig cycle technique you used below for inline style this also? and thus make it a class?
|
@hason do you have some time to update this PR for the suggested changes? I'd still like to see this, e.g. for 2.8. Thanks! |
8 tasks
|
@hason Do you time to finish this one? Or perhaps @javiereguiluz can take over? |
|
Closing in favour of #15792. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
