-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] REFS #11294 Controller class become abstract #12457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mickaelandrieu
commented
Nov 11, 2014
Q | A |
---|---|
Bug fix? | [no] |
New feature? | [no] |
BC breaks? | [yes] |
Deprecations? | [no] |
Tests pass? | [no] |
Fixed tickets | [#11294] |
License | MIT |
Doc PR | [] |
The protected, I can understand. But why the abstract? |
@iltar I agree @hhamon on this point: if all methods are now protected/private, the class shouldn't be intantiable. As an abstract class can't be instantiated, we improve the behavior of the use of this (helper/sugar) class. Curiously, Travis now complain and want to remove symfony 3.x release ... /c @fabpot
|
I tend to not use abstract on a class if it doesn't provide abstract methods nor missing methods from an interface, it looks weird to me. But I guess there's something to say for that as you shouldn't initiate this class yourself. If for any reason the abstract should be removed in a future patch, it will stay backwards compatible so it won't be a problem either way. 👍 |
@iltar the
The point is you don't need to have |
👍 |
wow, I wasn't stofized o_O such happy day ^^ |
👍 |
Can someone relaunch travis build? ping @fabpot |
Thank you @mickaelandrieu. |
…abstract (mickaelandrieu) This PR was merged into the 3.0-dev branch. Discussion ---------- [FrameworkBundle] REFS #11294 Controller class become abstract | Q | A | ------------- | --- | Bug fix? | [no] | New feature? | [no] | BC breaks? | [yes] | Deprecations? | [no] | Tests pass? | [no] | Fixed tickets | [#11294] | License | MIT | Doc PR | [] Commits ------- 0ab13b9 Publics methods are protected, class become abstract