[FrameworkBundle] remove deprecated method 'createEsi' #12663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianLB
commented
Nov 29, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | -- |
| License | MIT |
| Doc PR | -- |
|
Please do not remove method, we first need to merge deprecation notices |
|
@FlorianLB are you planning to finish this PR? The method mustn't be removed, but a depreciation error should be triggered instead. Have a look at other PRs of this type and also read Javier's gist, |
|
No. Depreciation error must be triggered in 2.7 and deprecated method must be removed in 3.0. This PR is about 3.0 not 2.7. I already did it and it has been merged (#12731). |
|
Sorry, didn't notice the target branch. We're not removing the methods just yet. |
|
👍 |
|
Thank you @FlorianLB. |
fabpot
added a commit
that referenced
this pull request
Jan 4, 2015
… (FlorianLB) This PR was merged into the 3.0-dev branch. Discussion ---------- [FrameworkBundle] remove deprecated method 'createEsi' | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | -- | License | MIT | Doc PR | -- Commits ------- 5e9aa16 [FrameworkBundle] remove deprecated method 'createEsi'
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.