Add LegacyPdoSessionHandler class #12994
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes made to the PdoSessionHandler in 2.6 introduced a backwards-compatability break for users upgrading from 2.5. This update introduces a LegacyPdoSessionHandler class that uses the old service's functionality. Users who cannot make schema updates or do not want to lose sessions can use LegacyPdoSessionHandler until 3.0.
|
+1 for this |
| @@ -125,6 +125,8 @@ HttpFoundation | |||
| There is also an [issue](https://github.com/symfony/symfony/issues/12834) | |||
| that affects Windows servers. | |||
|
|
|||
| A legacy class, `LegacyPdoSessionHandler` has been created to ease backwards-compatability issues when upgrading. | |||
|
@stof, I fixed three occurrences of this typo in the upgrade file. Thanks! |
There were a few incorrect spellings of "compatibility" in the 2.6 upgrade file. Update all occurrences of the typo to be the correct spelling.
225339e to
203b839
Compare
|
@jeremylivingston Can you create a PR for 2.7 where this new class is deprecated (and will be removed in 3.0)? Thanks. |
|
Thank you @jeremylivingston. |
fabpot
added a commit
that referenced
this pull request
Dec 21, 2014
This PR was squashed before being merged into the 3.0-dev branch (closes #12994). Discussion ---------- Add LegacyPdoSessionHandler class | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #12833 | License | MIT | Doc PR | N/A The changes made to the PdoSessionHandler in 2.6 introduced a backwards-compatability break for users upgrading from 2.5. This update introduces a LegacyPdoSessionHandler class that uses the old service's functionality. Users who cannot make schema updates or do not want to lose sessions can use LegacyPdoSessionHandler until 3.0. Commits ------- 20cb713 Add LegacyPdoSessionHandler class
fabpot
added a commit
that referenced
this pull request
Dec 21, 2014
This PR was squashed before being merged into the 3.0-dev branch (closes #12994). Discussion ---------- Add LegacyPdoSessionHandler class | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #12833 | License | MIT | Doc PR | N/A The changes made to the PdoSessionHandler in 2.6 introduced a backwards-compatability break for users upgrading from 2.5. This update introduces a LegacyPdoSessionHandler class that uses the old service's functionality. Users who cannot make schema updates or do not want to lose sessions can use LegacyPdoSessionHandler until 3.0. Commits ------- 22b183c Add LegacyPdoSessionHandler class
fabpot
added a commit
that referenced
this pull request
Dec 23, 2014
This PR was submitted for the 2.7 branch but it was merged into the 2.6 branch instead (closes #13068). Discussion ---------- Add LegacyPdoSessionHandler class | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #12833 | License | MIT | Doc PR | N/A Fix for #12994 on the 2.7 branch. The changes made to the PdoSessionHandler in 2.6 introduced a backwards-compatability break for users upgrading from 2.5. This update introduces a LegacyPdoSessionHandler class that uses the old service's functionality. Users who cannot make schema updates or do not want to lose sessions can use LegacyPdoSessionHandler until 3.0. Commits ------- 3bd1616 Add LegacyPdoSessionHandler class
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made to the PdoSessionHandler in 2.6 introduced a
backwards-compatability break for users upgrading from 2.5. This update
introduces a LegacyPdoSessionHandler class that uses the old service's
functionality.
Users who cannot make schema updates or do not want to lose sessions can
use LegacyPdoSessionHandler until 3.0.