[HttpKernel] [WebProfilerBundle] added HTTP status to profiler search result #13034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeab74 to
9d53f00
Compare
|
Nice one! |
|
@xelaris The format of the storage has changed in almost all minor versions of Symfony, so I think it's safe to assume the same for 2.7. |
|
👍 |
|
👍 |
| @@ -32,6 +33,7 @@ public function getFunctions() | |||
| { | |||
| return array( | |||
| new \Twig_SimpleFunction('profiler_dump', array($this, 'dumpValue')), | |||
| new \Twig_SimpleFunction('http_status_text', array($this, 'httpStatusText')), | |||
There was a problem hiding this comment.
your function depends only on HttpFoundation, so it should go in the HttpFoundationExtension of the bridge IMO
|
👍 (the failing tests are because the Form changes of 2.7 have not yet been merged into the master branch) |
|
Thank you @xelaris. |
|
Would be great if this could be added to the search form too. I'd like to be able to easily identify and filter on requests with exceptions. |
This was referenced Jun 26, 2015
fabpot
added a commit
that referenced
this pull request
Feb 9, 2016
This PR was submitted for the 3.0 branch but it was merged into the 3.1-dev branch instead (closes #17125). Discussion ---------- Webprofiler add status code to search form | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13034 | License | MIT With this PR, in the web profiler, you can filter by HTTP status codes. *Before filter*  *After filter*  Commits ------- 7d3700a Webprofiler add status code to search form
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…tus to profiler search result (xelaris) This PR was squashed before being merged into the 2.7 branch (closes symfony#13034). Discussion ---------- [HttpKernel] [WebProfilerBundle] added HTTP status to profiler search result | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#12944 | License | MIT | Doc PR | With this PR HTTP status codes are provided in the search results to simplify identification of particular requests. For the schema-less storage implementations (memcache(d), redis, mongodb) and the default file storage, it should work without purging existing profiles. But the code could be simplified, if it is an option to expect old profiles to be purged. For database driven storages (mysql, sqlite), the `sf_profiler_data` table must be dropped anyway (if the table isn't altered manually by adding the `status_code` column). Thus the changes are not fully BC.  Commits ------- 34ecda5 [HttpKernel] [WebProfilerBundle] added HTTP status to profiler search result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR HTTP status codes are provided in the search results to simplify identification of particular requests.
For the schema-less storage implementations (memcache(d), redis, mongodb) and the default file storage, it should work without purging existing profiles. But the code could be simplified, if it is an option to expect old profiles to be purged. For database driven storages (mysql, sqlite), the
sf_profiler_datatable must be dropped anyway (if the table isn't altered manually by adding thestatus_codecolumn). Thus the changes are not fully BC.