[Console] Define isVerbose(), etc. methods in OutputInterface #13086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o OutputInterface
|
👍 This was indeed on our list of changes for 3.0 |
|
@stof Didn't know. Where do I find that list? |
| * | ||
| * @return bool true if verbosity is set to VERBOSITY_QUIET, false otherwise | ||
| * | ||
| * @api |
|
Will reopen that once there is a 3.0 branch... |
|
@frne Why did you close? |
|
@Tobion For my comprehension: You want me to remove the |
|
@frne yes |
|
Thank you @frne. |
fabpot
added a commit
that referenced
this pull request
Jan 16, 2015
…terface (frne) This PR was squashed before being merged into the 3.0-dev branch (closes #13086). Discussion ---------- [Console] Define isVerbose(), etc. methods in OutputInterface Could / should the ```Symfony\Component\Console\Output\OutputInterface``` define the methods ```isQuiet()```, ```isVerbose()```, ```isVeryVerbose()``` and ```isDebug()```? Because the Interface already defines the verbosity constants and the ```getVerbosity()``` method, it will probalby be the right place to do so... | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 1ac95b1 [Console] Define isVerbose(), etc. methods in OutputInterface
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could / should the
Symfony\Component\Console\Output\OutputInterfacedefine the methodsisQuiet(),isVerbose(),isVeryVerbose()andisDebug()?Because the Interface already defines the verbosity constants and the
getVerbosity()method, it will probalby be the right place to do so...