[Debug] track and report deprecated classes and interfaces #13164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Dec 30, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
3f8fcdc to
515c4b8
Compare
|
|
||
| if (preg_match('#\n \* @deprecated (.*?)\r?\n \*(?: @|/$)#s', $refl->getDocComment(), $notice)) { | ||
| $notice = preg_replace('#\s*\r?\n \* +#', ' ', $notice[1]); | ||
| self::$deprecated[$name] = sprintf('The %s %s is deprecated %s', $name, class_exists($class, false) ? 'class' : 'interface', $notice); |
There was a problem hiding this comment.
given that you already have the ReflectionClass, using $refl->isInterface() would be more readable IMO
515c4b8 to
9729fa5
Compare
|
@stof comments addressed |
|
👍 this is a great way to report issues for people implementing deprecated interfaces or extending deprecated classes |
9729fa5 to
a541faf
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 30, 2014
…aces (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Debug] track and report deprecated classes and interfaces | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- a541faf [Debug] track and report deprecated classes and interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.