[Debug] Update exception messages to fix the tests #13186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakzal
commented
Dec 31, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
Tests are fine, maybe you missed a composer update before running them? |
|
Ok my bad, travis is failing. |
|
Exception message format has changed in #11034. #13173 added few more test cases in 2.5 and tests started to fail after 2.5 was merged to 2.6. |
|
I'll double check composer. I've been switching between branches quite a lot. |
|
Hum, too fast again, let me check more carefully :) |
|
Ok, your PR is good, 👍 sorry for the mistake |
|
@nicolas-grekas travis agrees ;) |
|
Thank you @jakzal. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 31, 2014
This PR was merged into the 2.6 branch. Discussion ---------- [Debug] Update exception messages to fix the tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- d5ccf01 [Debug] Update exception messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.