[WIP][2.6] Adding model_timezone and view_timezone upgrade notes #13224
Conversation
But this is still a incomplete imo, because this is a BC break, and I haven't included any details on how to work around the now-gone options.
|
Bah, and of course, this should be merged into 2.6 - my mistake :) |
|
I've not investigated this issue, but last time I had a look, I had the feeling that reverting this change was the best thing to do. |
|
@fabpot that makes sense to me - it probably should have been deprecated for 3.0 removal. The original issue (#7187) was basically that these options are "useless" (or perhaps just don't quite work as expected), so as far as I understand it, there's nothing special (e.g. security) that would have made it necessary to remove these abruptly - I think it was just a mistake :). We should prepare a PR to revert #12404 (also relates to #12911) and discuss there. Thanks! |
|
I would welcome such a PR and that actually would great to have it for 2.6.2. |
|
Please have a look at #13241. |
|
You're awesome @xabbuh :) |
|
Closing in favor of #13241 |
…ns (xabbuh) This PR was merged into the 2.6 branch. Discussion ---------- [Form] add back model_timezone and view_timezone options | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13224 | License | MIT | Doc PR | TODO (deprecate the `model_timezone` and `view_timezone` options) This reverts #12404. Commits ------- 1c4a75a add back model_timezone and view_timezone options
Hi guys!
#12404 introduced an accidental BC break to 2.6. This adds a note about this.
This is WIP because I'd like to add a note about how to actually change your
code to get things back and working. I'm talking on symfony/symfony-docs#4417
about this, because I'm not totally sure myself.
Thanks!